Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc in default implementation fatal functions on os.Exit() #1365

Merged
merged 2 commits into from
Jul 21, 2017
Merged

Add doc in default implementation fatal functions on os.Exit() #1365

merged 2 commits into from
Jul 21, 2017

Conversation

menghanl
Copy link
Contributor

@menghanl
Copy link
Contributor Author

cc @danjacques

@menghanl menghanl mentioned this pull request Jul 10, 2017
Closed
@menghanl menghanl force-pushed the logger_doc_os_exit branch from 53149fe to ca83238 Compare July 20, 2017 21:47
@menghanl menghanl force-pushed the logger_doc_os_exit branch from ca83238 to fd184f7 Compare July 20, 2017 21:49
@menghanl
Copy link
Contributor Author

@danjacques Just updated the comment on loggerV2 API to allow it to not call os.Exit(). Please take a look.

@danjacques
Copy link

This is more what I had in mind, and matches my expectations. Thanks!

@dfawley dfawley merged commit b34c88b into grpc:master Jul 21, 2017
@menghanl menghanl deleted the logger_doc_os_exit branch July 21, 2017 17:57
@menghanl menghanl added 1.6 Type: Documentation Documentation or examples labels Aug 24, 2017
@dfawley dfawley modified the milestone: 1.6 Release Aug 28, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.6 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@menghanl @danjacques @dfawley