-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensions support #448
Conversation
FYI there’s an example at graphql-tracing-example which is a simple opentracing example based on this PR |
@chris-ramon Any update on when this will be merged or reviewed? |
@chris-ramon Any luck with looking into this and make some feedback on the PR? |
@Fontinalis thanks a lot for working on this 👍 💯 I've being following the progress and this looks really great to me, the extensions API is small and simple to use. Also thanks for putting altogether and creating a neat example: Merging this one and let's address further improvements in a follow-up PRs. |
My two cents:
In any way, many thanks again for your hard work to bring this feature! |
I added an
Extension
interface that enables to build extensions for thegraphql
package.Using that, we can add support for the extensions and add tracing as an extension.
Added an example
examples/star-wars-with-trace
that shows how we could add a tracing extension.Using the interface we could add different extensions based on different tracing providers.
I'm interested in any kind of feedback, happy to work on this more.
Update 1:
Removed the example from the repo, and created one here
Fontinalis/graphql-tracing-example