Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace regexp.Compile with regexp.MustCompile #373

Merged
merged 2 commits into from
Jul 28, 2018
Merged

replace regexp.Compile with regexp.MustCompile #373

merged 2 commits into from
Jul 28, 2018

Conversation

quasilyte
Copy link
Contributor

Since error is ignored, it's better to use MustCompile.

Found using https://go-critic.github.io/overview#regexpMust-ref

@quasilyte
replace regexp.Compile with regexp.MustCompile
79674a8 
Since error is ignored, it's better to use MustCompile.

Found using https://go-critic.github.io/overview#regexpMust-ref
@quasilyte quasilyte mentioned this pull request Jul 28, 2018
Closed
@coveralls
Copy link

coveralls commented Jul 28, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 91.919% when pulling 1e154ea on Quasilyte:regexpMust into 4620584 on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 — thanks a lot @quasilyte!

@chris-ramon chris-ramon merged commit 8bad5f4 into graphql-go:master Jul 28, 2018
@quasilyte quasilyte deleted the regexpMust branch July 28, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quasilyte @coveralls @chris-ramon