Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use type switch with var binding #372

Merged
merged 1 commit into from
Jul 28, 2018
Merged

use type switch with var binding #372

merged 1 commit into from
Jul 28, 2018

Conversation

quasilyte
Copy link
Contributor

Allows to remove redundant type assertions inside case clauses.

Found using https://go-critic.github.io/overview.html#typeSwitchVar-ref

@quasilyte
use type switch with var binding
1d39c5c 
Allows to remove redundant type assertions inside case clauses.

Found using https://go-critic.github.io/overview.html#typeSwitchVar-ref
@quasilyte quasilyte mentioned this pull request Jul 28, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.919% when pulling 1d39c5c on Quasilyte:master into 990c305 on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 — thanks a lot @quasilyte!

@chris-ramon chris-ramon merged commit 4620584 into graphql-go:master Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quasilyte @coveralls @chris-ramon