Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalars: coerceFloat should return nil as default #352

Merged
merged 4 commits into from
Jul 13, 2018
Merged

scalars: coerceFloat should return nil as default #352

merged 4 commits into from
Jul 13, 2018

Conversation

chris-ramon
Copy link
Member

@chris-ramon chris-ramon commented Jul 13, 2018 •
edited
Loading

Overview

Test plan

  • Unit test

@coveralls
Copy link

coveralls commented Jul 13, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 80.75% when pulling 84839b3 on coerce-float-improvement into 796d223 on master.

@chris-ramon chris-ramon mentioned this pull request Jul 13, 2018
Merged
@chris-ramon chris-ramon merged commit 18b9a05 into master Jul 13, 2018
@chris-ramon chris-ramon deleted the coerce-float-improvement branch July 13, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-ramon @coveralls @jjeffery