Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow resolvers as pointer methods #302

Merged
merged 1 commit into from
Mar 24, 2018
Merged

allow resolvers as pointer methods #302

merged 1 commit into from
Mar 24, 2018

Conversation

gracenoah
Copy link
Contributor

fix #301

@gracenoah gracenoah force-pushed the resolvers-pointers branch from a2bfb25 to 3961264 Compare March 24, 2018 05:06
@coveralls
Copy link

coveralls commented Mar 24, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 81.006% when pulling 3961264 on gracenoah:resolvers-pointers into 4536a44 on graphql-go:master.

@chris-ramon
Copy link
Member

Thanks a lot @gracenoah!, also this is backwards compatible with non-pointer resolvers, we have a test for it: https://github.com/graphql-go/graphql/blob/master/executor_test.go#L1694

@chris-ramon chris-ramon merged commit c975a41 into graphql-go:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolvers can't be implemented with pointer methods
3 participants
@gracenoah @coveralls @chris-ramon