Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement resolving fields from FieldResolver source values #288

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Implement resolving fields from FieldResolver source values #288

merged 2 commits into from
Mar 8, 2018

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Mar 1, 2018

This allows users to return types that can implement their own FieldResolveFn.

@coveralls
Copy link

coveralls commented Mar 1, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 81.039% when pulling 3ca1c60 on dvic:value-field-resolver into 1c3c35a on graphql-go:master.

@chris-ramon
Copy link
Member

awesome!, def. agree on having an optional FieldResolver, very go idiomatic.
thanks a lot @dvic 🚢

@chris-ramon chris-ramon merged commit 79ee05c into graphql-go:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvic @coveralls @chris-ramon