Refactor Validation Tests JSON #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schemas defined in the tests.json are highly dependent on the order that graphql-js tests register them. This results in re-ordering of the schemas and updates to many/all of the schema index values referring to them in tests when new schemas are inserted. Attempting to add some stability to the JSON for future changes here by sorting the schemas, and referring to them by a SHA id of the schema content, rather than index ordering. This results in a large change here but hopefully smaller changes when adding and updating test cases from graphql-js in the future.
pavelnikolov
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schemas defined in the tests.json are highly dependent on the order that graphql-js tests register them. This results in re-ordering of the schemas and updates to many/all of the schema index values referring to them in tests when new schemas are inserted.
Attempting to add some stability to the JSON for future changes here by sorting the schemas, and referring to them by a SHA id of the schema content, rather than index ordering. This results in a large change here but hopefully smaller changes when adding and updating test cases from graphql-js in the future.