Move GraphQL types to package ast #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelnikolov
force-pushed
the
refactor-ast-package
branch
from
5b3c3d2 to
23676e2
Compare
KNiepok
pushed a commit
to spacelift-io/graphql-go
that referenced
this pull request
Feb 28, 2023
KNiepok
pushed a commit
to spacelift-io/graphql-go
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
astpackage for GraphQL types because it describes better the types it contains. Also, it would be better when using the types from other packages. For example,ast.ExecutableDefinitiongives more context thantypes.ExecutableDefinition.fixes: #582