Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made funMaps for the templates configurable and hot-reloadable #962

Merged
merged 3 commits into from
Jul 2, 2017

Conversation

tboerger
Copy link
Contributor

Now templates (function maps for helpers) can be better configured and we can keep the reload on request of the templates.

@codecov-io
Copy link

codecov-io commented Jun 30, 2017

Codecov Report

Merging #962 into develop will increase coverage by 0.78%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #962      +/-   ##
===========================================
+ Coverage    94.96%   95.75%   +0.78%     
===========================================
  Files           16       16              
  Lines         1410     1413       +3     
===========================================
+ Hits          1339     1353      +14     
+ Misses          58       49       -9     
+ Partials        13       11       -2
Impacted Files Coverage Δ
gin.go 90.64% <77.77%> (+0.64%) ⬆️
context.go 96.27% <0%> (+0.62%) ⬆️
debug.go 82.35% <0%> (+23.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470fe62...6d071c1. Read the comment docs.

@appleboy
Copy link
Member

appleboy commented Jul 2, 2017

LGTM

@appleboy
Copy link
Member

appleboy commented Jul 2, 2017

@tboerger Just add testing.

@javierprovecho javierprovecho added this to the 1.2 milestone Jul 2, 2017
@javierprovecho javierprovecho merged commit 54fe9df into develop Jul 2, 2017
@appleboy appleboy deleted the feat/func-maps branch July 2, 2017 08:54
javierprovecho added a commit that referenced this pull request Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants