Support google appengine for IsTerminal func. #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bo-Yi Wu <[email protected]>
Signed-off-by: Bo-Yi Wu <[email protected]>
Current coverage is 93.16% (diff: 100%)@@ master #754 diff @@
==========================================
Files 15 15
Lines 1283 1288 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1195 1200 +5
Misses 76 76
Partials 12 12
|
tboerger
approved these changes
Dec 4, 2016
|
@appleboy I have just tested and It looks good for me. |
|
@vermotr v1.1.4 is live, thanks for reporting the bug :) |
|
Thanks. Nice fix. That |
appleboy
added a commit
to appleboy/gorush
that referenced
this pull request
Dec 14, 2016
ref: gin-gonic/gin#754 Signed-off-by: Bo-Yi Wu <[email protected]>
appleboy
added a commit
to appleboy/gorush
that referenced
this pull request
Dec 14, 2016
ref: gin-gonic/gin#754 Signed-off-by: Bo-Yi Wu <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #744
Fixed #752
Fixed #753
cc @javierprovecho @tboerger @aviddiviner @kujenga