ref(widget-builder): Extract selection components #85248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares us to add state so we can define progressive selection. Most of it just pulls the content from the main visualize component into a smaller subcomponent. I noticed a few things as I was doing this:
spanColumnOptions
when it's a span dataset because it's already sortednumber
trailing item because if the aggregate isfield (no aggregate)
then we can actually have strings in this listfield (no aggregate)
because the way I had it before, it was filtering the options to string tags (the dataset helper for getting table options filtered out number tags), but now we can calculate the valid columns withfieldOptions
to include both strings and numbers