Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(widget-builder): Extract selection components #85248

Merged

Conversation

narsaynorath
Copy link
Member

This prepares us to add state so we can define progressive selection. Most of it just pulls the content from the main visualize component into a smaller subcomponent. I noticed a few things as I was doing this:

  • I start passing down the spanColumnOptions when it's a span dataset because it's already sorted
  • I removed the code that forces the span column options to have a number trailing item because if the aggregate is field (no aggregate) then we can actually have strings in this list
  • I changed the way the default gets calculated when going from an aggregate to field (no aggregate) because the way I had it before, it was filtering the options to string tags (the dataset helper for getting table options filtered out number tags), but now we can calculate the valid columns with fieldOptions to include both strings and numbers

@narsaynorath narsaynorath requested a review from a team as a code owner February 14, 2025 16:52
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 14, 2025
@narsaynorath narsaynorath changed the title Nar/ref/widget builder extract selection components ref(widget-builder): Extract selection components Feb 14, 2025
Copy link
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good but it seems that one of your changes may have broken table widgets in the spans dataset. When you change the aggregate to count from just a field (like GRADLE_VERSION) it shows an error. I think it has something to do with handling aggregate defaults?

@narsaynorath narsaynorath merged commit 472902e into master Feb 14, 2025
43 checks passed
@narsaynorath narsaynorath deleted the nar/ref/widget-builder-extract-selection-components branch February 14, 2025 19:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants