feat(derive_code_mapping): Support dry run mode #85065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dry run mode will allow testing the load of adding a new platform without creating the code mappings. It will also help collect the metrics and discover any errors.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Feb 12, 2025
| @@ -13,7 +13,22 @@ | |||
|
|
|||
|
|
|||
| # We only care about extensions of files which would show up in stacktraces after symbolication | |||
| SUPPORTED_EXTENSIONS = ["js", "jsx", "tsx", "ts", "mjs", "py", "rb", "rake", "php", "go", "cs"] | |||
| SUPPORTED_EXTENSIONS = [ | |||
There was a problem hiding this comment.
I'm not making any changes besides sorting it.
| @@ -1,3 +1,13 @@ | |||
| SUPPORTED_INTEGRATIONS = ["github"] | |||
| # Any new languages should also require updating the stacktraceLink.tsx and repo_trees.py SUPPORTED_EXTENSIONS | |||
| SUPPORTED_LANGUAGES = ["javascript", "python", "node", "ruby", "php", "go", "csharp"] | |||
| SUPPORTED_LANGUAGES = [ | |||
There was a problem hiding this comment.
I'm not making any changes besides sorting it.
| "ruby", | ||
| ] | ||
| # These languages will run as dry-run mode by default | ||
| DRY_RUN_PLATFORMS: list[str] = [] |
There was a problem hiding this comment.
We will add Java at a later point or even use an option to control it.
| if frame and frame.get("in_app") and frame.get("filename") | ||
| } | ||
| stacktrace_paths.update(paths) | ||
| for frame in frames: |
There was a problem hiding this comment.
This is equivalent, however, I'm going to add more to it in my next PR.
|
|
||
| try: | ||
| installation = get_installation(org) | ||
| trees = get_trees_for_org(installation, org, extra) | ||
| trees_helper = CodeMappingTreesHelper(trees) | ||
| code_mappings = trees_helper.generate_code_mappings(stacktrace_paths) | ||
| set_project_codemappings(code_mappings, installation, project) | ||
| if event.platform not in DRY_RUN_PLATFORMS: | ||
| set_project_codemappings(code_mappings, installation, project) |
There was a problem hiding this comment.
This is what creates code mappings.
| def create_event( | ||
| self, frames: Sequence[Mapping[str, str | bool]], platform: str | None = None | ||
| ) -> Event: | ||
| def create_event(self, frames: Sequence[Mapping[str, str | bool]], platform: str) -> Event: |
armenzg
added this to the Automate Code Mappings & In-App Stack Trace Rules for Java projects milestone
JoshFerge
approved these changes
Feb 12, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #85065 +/- ##
========================================
Coverage 87.93% 87.94%
========================================
Files 9616 9611 -5
Lines 542926 542173 -753
Branches 20996 20950 -46
========================================
- Hits 477445 476799 -646
+ Misses 65172 65067 -105
+ Partials 309 307 -2 |
MichaelSun48
approved these changes
Feb 12, 2025
|
Heads up: I reran |
Thanks! It seems to still be there. I will merge master. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
PR reverted: c841d5a |
getsentry-bot
added a commit
that referenced
this pull request
Feb 13, 2025
This reverts commit 322dbe7. Co-authored-by: armenzg <[email protected]>
armenzg
added a commit
that referenced
this pull request
Feb 13, 2025
The dry run mode allows testing the load of adding a new platform without creating the code mappings. It also helps collect metrics and discover errors. This handles the issues found in #85065.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dry run mode will allow testing the load of adding a new platform without creating the code mappings.
It will also help collect the metrics and discover any errors.