meson: Do not export private headers in libzstd_dep to avoid name clash #4153
Conversation
This way libzstd_dep does not override, for instance, <xxhash.h>
|
Hi @artem! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Signed CLA. perhaps cc @eli-schwartz for review? |
| @@ -124,7 +124,7 @@ libzstd = library('zstd', | |||
| version: zstd_libversion) | |||
|
|
|||
| libzstd_dep = declare_dependency(link_with: libzstd, | |||
| include_directories: libzstd_includes) | |||
| include_directories: join_paths(zstd_rootdir,'lib')) # Do not expose private headers | |||
There was a problem hiding this comment.
This makes sense to me. It corresponds to the only 3 headers that get installed, and libzstd_dep is supposed to be equivalent to the installed zstd library.
It's still possible for people to do something filthy like #include <common/xxhash.h> but if they do then they broke it themselves, so they get to keep both pieces.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
The second commit fixes tests and contrib that I broke =) |
This way libzstd_dep does not override, for instance, <xxhash.h>