Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esutil: Modify the BulkIndexerConfig.Client type to esapi.Transport #957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

esutil: Modify the BulkIndexerConfig.Client type to esapi.Transport #957

wants to merge 1 commit into from

Conversation

zaneli
Copy link

@zaneli zaneli commented Feb 24, 2025

Now, when using a pre-declared TypedClient, a separate Client instance had to be created via NewClient to pass it to BulkIndexerConfig.

To improve usability, this change updates the type of BulkIndexerConfig.Client to esapi.Transport, allowing both Client and TypedClient to be passed directly.

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Feb 24, 2025 •
edited
Loading

💚 CLA has been signed

@zaneli zaneli marked this pull request as draft February 24, 2025 14:42
@zaneli zaneli marked this pull request as ready for review February 24, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zaneli