Add exception to core.get to handle index_not_found & document not found #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
reviewed
Jun 27, 2023
| exceptions: [ | ||
| { | ||
| statusCodes: [404] | ||
| body: GetResult<TDocument> | ErrorResponseBase |
There was a problem hiding this comment.
Can you add a comment explaining that ErrorResponseBase will be returned if the index doesn't exist, and GetResult if the id doesn't exist, and in that case it will only contain "found": false, _id and _index?
And for the sake of nitpicking flip the two members of the union: start with the result for the unknown index and finish with the result for the unknown id 😉
There was a problem hiding this comment.
Documentation added!
The order is consistent with the existing exceptions in the rest of the specification; I suggest we keep it that way.
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
…und (#2156) * Add exception to core.get to handle index_not_found & document not found * add documentation to get exception
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
…und (#2156) * Add exception to core.get to handle index_not_found & document not found * add documentation to get exception
This was referenced Jun 27, 2023
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
…und (#2156) * Add exception to core.get to handle index_not_found & document not found * add documentation to get exception
Anaethelion
added a commit
that referenced
this pull request
Jun 27, 2023
…und (#2156) (#2157) * Add exception to core.get to handle index_not_found & document not found * add documentation to get exception Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Jun 27, 2023
…und (#2156) (#2158) * Add exception to core.get to handle index_not_found & document not found * add documentation to get exception Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Jun 27, 2023
…und (#2156) (#2159) * Add exception to core.get to handle index_not_found & document not found * add documentation to get exception Co-authored-by: Laurent Saint-Félix <[email protected]>
|
Found in elastic/go-elasticsearch#678 |
swallez
pushed a commit
that referenced
this pull request
Jul 5, 2023
…und (#2156) * Add exception to core.get to handle index_not_found & document not found * add documentation to get exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an exception to the
core.getresponse to handleindex_not_found_exceptionand document not found.