Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Clean up command client lib #974

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Feb 5, 2025

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@cloudxxx8 cloudxxx8 requested a review from jinlinGuan February 5, 2025 12:41
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.

Project coverage is 43.02%. Comparing base (c739c72) to head (ebecdaf).

Files with missing lines Patch % Lines
clients/interfaces/mocks/CommandClient.go 0.00% 27 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
- Coverage   43.08%   43.02%   -0.06%     
==========================================
  Files         117      117              
  Lines        7151     7147       -4     
==========================================
- Hits         3081     3075       -6     
- Misses       3727     3731       +4     
+ Partials      343      341       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jinlinGuan jinlinGuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 824688c into edgexfoundry:main Feb 6, 2025
3 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-870 branch February 6, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants