Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move winresources into cmd/docker #5909

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

thaJeztah
Copy link
Member

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Mar 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.29%. Comparing base (2eec746) to head (44e5100).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5909      +/-   ##
==========================================
+ Coverage   59.26%   59.29%   +0.02%     
==========================================
  Files         357      357              
  Lines       29771    29771              
==========================================
+ Hits        17645    17653       +8     
+ Misses      11153    11144       -9     
- Partials      973      974       +1     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah thaJeztah force-pushed the move_winresources branch 3 times, most recently from c905642 to c136b55 Compare March 8, 2025 20:52
@thaJeztah thaJeztah requested a review from crazy-max March 8, 2025 21:19
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the move_winresources branch from c136b55 to 44e5100 Compare March 8, 2025 21:20
@thaJeztah thaJeztah changed the title move winresources into cmd/dockerd move winresources into cmd/docker Mar 8, 2025
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

Thx!

@thaJeztah thaJeztah merged commit 571124d into docker:master Mar 10, 2025
98 checks passed
@thaJeztah thaJeztah deleted the move_winresources branch March 10, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants