Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to github.com/jackc/pgx/v5 #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Sep 20, 2024

Migrate from database/sql and github.com/jmoiron/sqlx to github.com/jackc/pgx/v5.

If I understood a94b201 correctly, you were planning to do this anyway.

If you don't want to use this change, I'm happy to only use it in a fork of this project.

Let me know what you think.

@prochac
Copy link
Contributor

prochac commented Sep 20, 2024

The rewrite doesn't have consensus :D
One option is to support, and test all drivers.
And also provide support for non-std lib pgx interface through interface+adapter.

The second option is to go fully pgx, since it's the no.1 Postgres driver, and this project is, and ever will be Postgres-only.

I guess we could decide next week what path we want to go. And if I remember correctly, the full-pgx is the popular.
But we wanted to prepare all possible breaking changes, so we serve them all at once.

@prochac
Copy link
Contributor

prochac commented Oct 21, 2024

Ok, so we agreed to go with pgx. (And I can try to add stdlib support later)

Before merge, let me try it from a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants