Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add size metrics to Minio storage code #558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team March 6, 2025 21:38
Copy link

overwatch-beta bot commented Mar 6, 2025

✅ Sentry found no issues in your recent changes ✅

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.69%. Comparing base (42cd874) to head (cfc5b2f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
shared/storage/write.py 55.55% 2 Missing and 2 partials ⚠️
shared/storage/compression.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   88.72%   88.69%   -0.04%     
==========================================
  Files         461      461              
  Lines       13146    13181      +35     
  Branches     1510     1514       +4     
==========================================
+ Hits        11664    11691      +27     
- Misses       1165     1169       +4     
- Partials      317      321       +4     
Flag Coverage Δ
shared-docker-uploader 88.69% <80.76%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
shared/storage/write.py 55.55% 2 Missing and 2 partials ⚠️
shared/storage/compression.py 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overwatch approves, I approve

Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #558 will not alter performance

Comparing joseph/minio-metrics (cfc5b2f) with main (d6735e6)

Summary

✅ 17 untouched benchmarks

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to try Sentry span attributes for this. we can probably try this out.

Comment on lines 35 to 36
MINIO_WRITE_TIME_SUMMARY = Summary(
"minio_write_time",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also add tags to sentry spans, and filter/aggregate over those.

- keep track of number of compressed bytes in GZipStreamReader
- add sentry_sdk.trace to Minio read_file, write_file methods
- add impl type and compressed bytes write size as data in spans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants