Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - Tell users if they're already logged in #1955

Merged
merged 2 commits into from
Nov 9, 2024
Merged

CLI - Tell users if they're already logged in #1955

merged 2 commits into from
Nov 9, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Nov 6, 2024 •
edited
Loading

Description of Changes

Currently, spacetime login just silently returns if the user is already logged in.

This PR adds a message informing the user that they are already logged in.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

  • When I run spacetime login, I see the message.
$ cargo run -- login
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.27s
     Running `target/debug/spacetime login`
You are already logged in.
If you want to log out, use spacetime logout.

@bfops bfops marked this pull request as ready for review November 8, 2024 18:43
@bfops bfops requested a review from cloutiertyler as a code owner November 8, 2024 18:43
@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels Nov 8, 2024
cloutiertyler
cloutiertyler approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@bfops bfops added this pull request to the merge queue Nov 9, 2024
Merged via the queue into master with commit fdb1a71 Nov 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutiertyler cloutiertyler cloutiertyler approved these changes

Assignees
No one assigned
Labels
CLI only This change only affects the CLI behavior release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfops @cloutiertyler