Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix improperly named counter metrics #1409

Closed
joshua-spacetime opened this issue Jun 12, 2024 · 0 comments · Fixed by #1411
Closed

Fix improperly named counter metrics #1409

joshua-spacetime opened this issue Jun 12, 2024 · 0 comments · Fixed by #1411
Assignees
@joshua-spacetime

Comments

@joshua-spacetime
Copy link
Collaborator

We have the following warnings when querying metrics from grafana

PromQL info: metric might not be a counter, name does not end in _total/_sum/_count/_bucket

This is due to our counter metrics ending in _cumulative rather than _total.
@joshua-spacetime joshua-spacetime self-assigned this Jun 12, 2024
joshua-spacetime added a commit that referenced this issue Jun 12, 2024
@joshua-spacetime
fix(1409): Counter metric names
155e5cd 
Closes #1409.

Grafana expects the names of counter metrics to end in _total.
@joshua-spacetime joshua-spacetime mentioned this issue Jun 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshua-spacetime joshua-spacetime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(1409): Counter metric names clockworklabs/SpacetimeDB
1 participant
@joshua-spacetime