feat: new implementation of timeout functionality for all toolkits #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
13 tasks
lightaime
reviewed
Feb 14, 2025
camel/toolkits/base.py
Outdated
| def with_timeout(func): | ||
| @functools.wraps(func) | ||
| def wrapper(self, *args, **kwargs): | ||
| timeout = getattr(self, "timeout", None) |
There was a problem hiding this comment.
Can we put timeout as the input argument? Also can we move this into utils so we can use this for other modules?
There was a problem hiding this comment.
Now the specification is that timeout is an argument in toolkit initialization. Do you mean to have it in every member function of the toolkits class?
There was a problem hiding this comment.
update here: 0fc43f7
and will merge this PR, thanks @MuggleJinx for the contribution! Let me know if you have any further questions~
lightaime
reviewed
Feb 14, 2025
lightaime
reviewed
Feb 14, 2025
lightaime
reviewed
Feb 14, 2025
lightaime
reviewed
Feb 14, 2025
lightaime
reviewed
Feb 14, 2025
Wendong-Fan
approved these changes
Feb 18, 2025
This was
linked to
issues
Feb 18, 2025
zoezyn
pushed a commit
that referenced
this pull request
Feb 18, 2025
…1595) Co-authored-by: Wendong <[email protected]>
JoyceXu02
pushed a commit
that referenced
this pull request
Feb 24, 2025
…1595) Co-authored-by: Wendong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New implementation of #1519 and #1507. Adding timeout function to all toolkits.
Checklist
Fixes #issue-numberin the PR description (required)pyproject.tomlandpoetry.lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!