Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track RPC v2 CBOR feature #3422

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

arandito
Copy link
Contributor

@arandito arandito commented Mar 7, 2025

Description

This PR adds support for tracking usage of the PROTOCOL_RPC_V2_CBOR feature.

User agent strings can now include an 'M' in the m/ metrics field when an operation is called using the Smithy RPC v2 CBOR protocol.

User agent string example:

Boto3/1.37.9 md/Botocore#1.37.9 ua/2.1 os/macos#24.3.0 md/arch#arm64 lang/python#3.12.8 md/pyimpl#CPython m/M cfg/retry-mode#legacy Botocore/1.37.9

See #3389 for more details on client feature tracking.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.97%. Comparing base (6300f6b) to head (228b96e).
Report is 50 commits behind head on develop.

Files with missing lines Patch % Lines
botocore/args.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3422      +/-   ##
===========================================
+ Coverage    92.94%   92.97%   +0.02%     
===========================================
  Files           66       67       +1     
  Lines        14956    15056     +100     
===========================================
+ Hits         13901    13998      +97     
- Misses        1055     1058       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants