KAFKA-18195: Fix Kafka Streams broker compatibility matrix #18258
Conversation
|
The KS column does not seem to be correct? KS 4.0 is compatible to brokers 2.1+ or newer... |
|
Also the cell for |
|
Alos, Kafka Streams 0.10.0 (and all other older version) should be compatible to newer brokers, right (except 4.0, for which we remove older RPC versions, and thus only KS 2.1+ would work with 4.0 brokers). |
FrankYang0529
force-pushed
the
KAFKA-18915
branch
3 times, most recently
from
3c38bd4 to
a5013b8
Compare
|
Hi @mjsax, thanks for the review. I follow the suggestion to update a version. Could you take a look when you have time? Thank you. 
|
…es blank in Kafka Streams broker compatibility matrix Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18915
branch
from
a5013b8 to
42cfa29
Compare
|
Seems we are getting close to vote KIP-1124. Might be good to start updating this PR? I think, we should cut down the matrix to simplify it and only include broker versions 2.1.x to 4.0.x and KS versions 2.3.x to 4.0.x? And refer to 3.9 docs (with a link) for older versions? |
FrankYang0529
changed the title
Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
|
Hi @mjsax, thanks for the comment. Not sure whether KS version 2.3.x is typo. From KIP-1124 and streams_upgrade_test.py, the lowest KS version is v2.4.x.
|
|
Ah, yes, 2.4... my bad :) |
docs/streams/upgrade-guide.html
Outdated
| <td>2.1.x and<br>2.2.x and<br>2.3.x and<br>2.4.x and<br>2.5.x and<br>2.6.x and<br>2.7.x and<br>2.8.x and<br>3.0.x and<br>3.1.x and<br>3.2.x and<br>3.3.x and<br>3.4.x and<br>3.5.x and<br>3.6.x and<br>3.7.x and<br>3.8.x and<br>3.9.x</td> | ||
| <td>4.0.x</td> | ||
| </tr> | ||
| <tr> | ||
| <td>0.10.0.x</td> | ||
| <td>2.4.x and<br>2.5.x</td> | ||
| <td>compatible with exactly-once v2 turned off</td> |
There was a problem hiding this comment.
2.4.x and 2.5.x do not have EOSv2 -- so this is confusing... There is nothing to be turned on/off -- EOSv2 was only added in 2.6.0 release.
So it might be easier to just say "compatible" ?
docs/streams/upgrade-guide.html
Outdated
| <td></td> | ||
| <td></td> | ||
| <td>compatible; enabling exactly-once v2 requires broker version 2.5.x or higher</td> | ||
| <td>compatible</td> |
There was a problem hiding this comment.
Given that KS 4.0.x does not include EOSv1 any longer, we should also call this out? KS 4.0 with EOSv2 does require broker 2.5+ too.
Given that we don't have EOSv1 in KS 4.0 any longer, we could say "enabling exactly-once requires broker version 2.5.x or higher" (ie, drop the v2 thing).
Or: we just merge 4.0 row with 2.6.x - 3.9.x row?
There was a problem hiding this comment.
Sorry for late update. I merge 4.0 to 2.6.x - 3.9.x, so we don't need to update the description. Thanks.
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
changed the title
In the client-broker compatibility matrix of the Kafka Streams docs, we use an empty cell to indicate "incompatible". This is confusing and some have mentioned it looks like an error rather than intentional, so we should instead just explicitly enter the word "incompatible". See this comment for context: #17906 (comment)
Preview:
Reviewers: Matthias J. Sax [email protected]
Previous Preview: