feat: org imports on format #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerdav
changed the title
joerdav
force-pushed
the
organise-imports
branch
from
84cd57c to
b9837aa
Compare
joerdav
force-pushed
the
organise-imports
branch
from
b9837aa to
d15ddbd
Compare
|
Looking good! I'll give it a proper review when I can. Thanks so much for this, it's such a cool feature. |
|
No problem! Let me know if you have questions about the code, or any changes for me to make. |
a-h
requested changes
Jun 22, 2024
| // Generate code. | ||
| gw := bytes.NewBuffer(nil) | ||
| var updatedImports []*ast.ImportSpec | ||
| var eg errgroup.Group |
generator/generator.go
Outdated
| // var templ_7745c5c3_CSSBuilder strings.Builder | ||
| if _, err = g.w.WriteIndent(indentLevel, "var templ_7745c5c3_CSSBuilder strings.Builder\n"); err != nil { | ||
| // templ_7745c5c3_CSSBuilder, _, release := templruntime.WriterToBuffer(nil) | ||
| if _, err = g.w.WriteIndent(indentLevel, "templ_7745c5c3_CSSBuilder, _, release := templruntime.WriterToBuffer(nil)\n"); err != nil { |
There was a problem hiding this comment.
I think release should be called templ_7745c5c3_release.
generator/generator.go
Outdated
| if _, err = g.w.WriteIndent(indentLevel, "templ_7745c5c3_CSSBuilder, _, release := templruntime.WriterToBuffer(nil)\n"); err != nil { | ||
| return err | ||
| } | ||
| if _, err = g.w.WriteIndent(indentLevel, "defer release()\n"); err != nil { |
There was a problem hiding this comment.
As per above... templ_7745c5c3_release()
a-h
approved these changes
Jun 22, 2024
This was referenced Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.