Update modules #31
Closed
Update modules #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Cgiraldo, Thank you for your contribution! Considering there's a lot library updates, I need to testing this pull request in our internal testing repo and going through the open-source legal scanning process, so currently I'm not able to directly merge your pull request, I will add your name & github account in an contribution list in our next release to prove your contribution, is this ok for you? |
|
It is Ok. |
|
i have also include a commit to support zcu102 board. Thanks to @Vae1997 and the repo: https://github.com/Vae1997/zcu102-fpga-device-plugin-demo |
|
Github repo was transfered to Gradiant Organization: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1 instead of k8s.io/kubernetes/pkg/kubelet/apis/deviceplugin/v1beta1.
Use sirupsen/logrus instead of Sirupsen/logrus sirupsen/logrus#570 (comment)