Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] a11y-tooltip-interactive-trigger raises false positives on components #315

Open
khiga8 opened this issue Feb 12, 2025 · 0 comments
Open
Assignees
Labels

Comments

@khiga8
Copy link
Contributor

khiga8 commented Feb 12, 2025

When I tested turning this rule on in dotcom (https://github.com/github/github/pull/361996), I noticed that false positives are raised for custom components like:

<Tooltip>
   <HistoryLinkButton ..>
</Tooltip>

Currently the rule only allows certain components, and rejects whatever it doesn't recognize.
A potential approach is to support an "allowed config" and have consumers add to it. I worry this might still be noisy though to consumers.

An alternative is to rewrite the rule to be more conservative and consider a denylist of components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants