-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on pkg.go.dev not available due to licence file and tags #169
Comments
@rogchap Thanks for bringing this to our attention. We are working to address it. |
I think what's causing the problem is the repository layout. When using the major directory model, everything must exist in that directory, including licenses/readmes. I'd like to request the removal of the V3 directory, moving everything up to root and instead use the layout that Google uses for their Github library:
The major directory model has been causing pain for me, since the repository is unsearchable via Github without finding both v2 and v3 code. |
I might have been a little overzealous, but the license file was copied to both the |
#254 has been merged. When released, it should fix this issue. |
We're targeting a Monday afternoon (January 11, 2021) release. |
https://pkg.go.dev/github.com/newrelic/go-agent/v3/newrelic -- Issue resolved as of 2021-01-11 3:40pm Pacific time. |
The integrations' documentation still isn't showing up, most likely due to tags not being updated. I'm reopening this issue until we can see documentation for the tools in v3/integrations. |
@RichVanderwal Likely a tagging problem, yes. Once the tag for the 3.X series is pushed/scanned/updated, it should trigger an update. You could also try running:
Update: Response from the server:
|
Still working on this. Testing the two updated integration packages nrawssdk-v2 and nrgrpc, and also with one un-updated integration, nrzap. |
The recent change to the license file has caused the documentation to be removed from https://pkg.go.dev site:
https://pkg.go.dev/github.com/newrelic/go-agent/v3/newrelic?tab=overview
The text was updated successfully, but these errors were encountered: