Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urls used in css background images should be encoded #7903

Closed
2 of 7 tasks
shefalijoshi opened this issue Oct 18, 2024 · 1 comment · Fixed by #7906
Closed
2 of 7 tasks

urls used in css background images should be encoded #7903

shefalijoshi opened this issue Oct 18, 2024 · 1 comment · Fixed by #7906
Labels

Comments

@shefalijoshi
Copy link
Contributor

Summary

When urls used for the backgroundImage property of css have special characters (like spaces), the urls don't work.

Expected vs Current Behavior

Urls with spaces and special characters should work for css background images

Steps to Reproduce

  1. For imagery layers, use a url where the file name / url has a space in it. (eg. this_is_an_image url.png)
  2. Toggle the layer on in openmct
  3. Observe that the layer is not displayed

Environment

  • Open MCT Version: 4.1.x
  • Deployment Type: all
  • OS: all
  • Browser: all

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@shefalijoshi
Copy link
Contributor Author

shefalijoshi commented Oct 18, 2024

Testing instructions:
Ensure that the following components work correctly:

  1. Display layout images - Use an image URL with a space in it.
  2. Imagery View
  • The main image
  • Imagery layers (overlays)
  • Thumbnail images
  1. Object styles editor - Look at the styles for an image layout item in the inspector where the image layout item URL has a space in it.
  2. AppLogo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant