Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balancergroup: Add test coverage #8118

Open
arjan-bal opened this issue Feb 25, 2025 · 0 comments
Open

balancergroup: Add test coverage #8118

arjan-bal opened this issue Feb 25, 2025 · 0 comments
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. P2 Type: Testing

Comments

@arjan-bal
Copy link
Contributor

We should add test cases that call the following methods on balancergroup after it's closed to cover guard blocks in various places.

  1. ExitIdle
  2. ExitIdleOne
  3. UpdateClientConnState
  4. ResolverError

Context: #8095 (review)
@arjan-bal arjan-bal added Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Testing labels Feb 25, 2025
@arjan-bal arjan-bal mentioned this issue Feb 25, 2025
Merged
@arjan-bal arjan-bal added the P2 label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. P2 Type: Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arjan-bal