Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object::exports should return some kind of iterator #429

Open
Ben-Lichtman opened this issue Mar 24, 2022 · 1 comment
Open

Object::exports should return some kind of iterator #429

Ben-Lichtman opened this issue Mar 24, 2022 · 1 comment

Comments

@Ben-Lichtman
Copy link

Object::exports should return some kind of iterator.

Currently It requires allocating a Vec, which should be unnecessary...
@philipc
Copy link
Contributor

philipc commented Aug 22, 2022

Changing to an iterator and using a trait for the iterator items would also allow more file format specific information to be exposed. For example, it would be useful to know which ELF exports are for TLS (https://github.com/bjorn3/rustc_codegen_cranelift/pull/1269#issuecomment-1221935414).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philipc @Ben-Lichtman