Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uppercase from the go.mod #286

Closed
psankar opened this issue Feb 23, 2022 · 1 comment
Closed

Remove uppercase from the go.mod #286

psankar opened this issue Feb 23, 2022 · 1 comment

Comments

@psankar
Copy link

psankar commented Feb 23, 2022

Right now, the go.mod defines the module name as:

module github.com/DATA-DOG/go-sqlmock

There are problems when we use uppercase names as part of the urls. For example: Artifactory has issues with package name and version in upper case and does not download the packages https://www.jfrog.com/jira/si/jira.issueviews:issue-html/RTFACT-18624/RTFACT-18624.html . It would be a good idea to rename the DATA-DOG to data-dog in the go.mod. If we keep the name in lower case, it would work even if the github project name is in uppercase iiuc.

@dolmen
Copy link
Contributor

dolmen commented Apr 22, 2022

Changing to lowercase would be a new import path. This is the same as forking the project.

I have already seen the case change for logrus a few years ago, and it was a mess.

If Artifactory has issues with this project, that's Artifactory that has to be fixed.

@l3pp4rd l3pp4rd closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants